feat(tracing): send both breadcrumbs and logs by default #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #878 +/- ##
==========================================
+ Coverage 73.33% 73.39% +0.05%
==========================================
Files 64 64
Lines 7423 7423
==========================================
+ Hits 5444 5448 +4
+ Misses 1979 1975 -4 🚀 New features to boost your workflow:
|
Swatinem
approved these changes
Aug 4, 2025
|
One might initialize the |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new function
default_event_filter_with_logswhich is the same as the default one but also sends logs for anything at or above INFO.If the
sentrycrate is used with thelogsfeature and there's already a Hub active, grabenable_logsfrom the associated client and use the new default filter with logs if possible.If there's no hub, still use the new function that creates logs.
If
enable_logs: false, the client will drop the logs later anyways.Users still need to opt into sending logs by enabling the feature flag and setting
enable_logs: true, but this makes it easier if you don't want to set up a custom event filter, and it also makes the onboarding docs simpler.Close #871